-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register GCP auth plugin #6
Register GCP auth plugin #6
Conversation
Could anybody restart the travis build? Looks like it stuck. |
That's very interesting find - thank you for the PR. Sorry to cause any pain, but we always prefer to keep vendor changes separate - i.e. 1 PR for anything in Also I'd love to have such change to be covered by a test. Is there any way I can reproduce #5 ? Were you able to reproduce it reliably? Did you need any specific GKE settings or did you deploy K8S to any specific environment (GCloud, AWS) with any specific settings? Thanks. |
No problem, I'll split this PR. Yes, I can reproduce it reliably. It happens every time I try to create cluster in gcloud. Here the example of terraform file
|
8bed204
to
97dd955
Compare
I've splitted PR. |
Regarding the tests - I am not sure that I understand how I can properly test this case without using real GKE cluster. I would love to hear any suggestions. |
I was able to reproduce the issue, I'll take a look if there's any reasonable way to test this. |
👍 Experiencing the same here. |
Could we import the whole auth package? I have a very similar issue, which could be solved with that: #8 |
I took some time to read the relevant code to understand the problem better and I agree with @bonifaido - we should initialize all available auth providers - that is
which also means adding more packages to vendor. There are currently 3 ( @e-max Would you mind updating the PR accordingly, so we can resolve the issue? I managed to create a test for it here: https://github.com/terraform-providers/terraform-provider-kubernetes/compare/b-test-auth-providers#diff-5b8f5184f088cd547dff9f4eb33ad883R35 - feel free to cherry-pick that to you branch - or I can do it prior to merging. |
Yes, sure - I'll take care of it later today. |
Hm. We have a small impediment here. We use |
9aaf2ab
to
b53789d
Compare
We certainly want to keep it pinned to a tag, ideally - happy to leave out Azure here, until it becomes part of a tagged release in which case we'd raise a separate PR. Would you mind submitting the vendor changes separately - as before, please? 😃 |
Oh, I missed #11 sorry - just looking at it 👀 |
As described here hashicorp/terraform#15244 (comment) client-go doesn't enable GCP auth plugin by default. We have to do it explicitly
b53789d
to
7b562a7
Compare
@e-max I decided to rebase your branch and remove the vendor commit from here as it's already in master & force push to speed things up and finish this PR. I hope you don't mind. Thanks for all the work and patience in all the feedback loops. 👍 🎉 |
Thank you @e-max and everyone for fixing! |
Thanks @e-max |
I still have this issue in v0.9.10 of Terraform. |
@burdiyan You should try terraform v.0.10+ with terraform-provider-kubernetes built from a master branch. |
@e-max It worked, thanks a lot! So on Terraform v0.9.10 the Kubernetes provider is broken then? |
i'm running version
|
Per changelog this bugfix was released in There are no plans of backporting this to |
This PR intends to address the bug reported in this issue
#5
As described here hashicorp/terraform#15244 (comment)
client-go doesn't enable GCP auth plugin by default. We have to do it explicitly.
Fixes #5
Fixes #8